opendev/infra-manual
Code Issues Proposed changes

Add description of Work in Progress

Browse Source 
Change-Id: I9ce84f5db0aac5e3e5e0ef8a1d8c3497903c16ac
This commit is contained in:
Pavel Sedlák
2014-07-16 12:25:40 +02:00
committed by Andreas Jaeger
parent d87b8e2bdf
commit c6ddf44ef0
1 changed files with 17 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
doc/source/developers.rst
View File

@@ -392,7 +392,23 @@ https://wiki.openstack.org/wiki/ReviewChecklist
Work in Progress
----------------
TODO
To get early feedback on a change which is not fully finished yet, you
can submit a change to gerrit and mark it as "Work in Progress" (WIP).
.. note::
The OpenStack Gerrit system does not support drafts, use
"Work in Progress" instead.
To do so, after submitting a change to gerrit in usual way (``git review``),
You should go to gerrit, and do `Code Review`_ of your own change while
setting "Workflow" vote to "-1", which marks the change as WIP.
This allows others to review the change, while at the same time
blocking it from being merged, as you already plan to continue working on it.
.. note:: After uploading a new patchset, this -1 (WIP) vote disappears.
So if you still plan to do additional changes, do not forget to
set Workflow to -1 on the new patchset.
Merging
=======