From d4b2082152a36553361236a573e7e8f00d9fbfa8 Mon Sep 17 00:00:00 2001 From: Clark Boylan Date: Wed, 4 Mar 2020 11:09:45 -0800 Subject: [PATCH] Cleanup Gerrit Approval event note The note here about how Gerrit Approval events are emitted was true for older Gerrit. Current Gerrit (including the one we are running) emits the event details on all events which fixes this problem for us. Change-Id: Iedde959407c1ea214d4616f71d89468a85109a0b --- doc/source/core.rst | 7 ------- 1 file changed, 7 deletions(-) diff --git a/doc/source/core.rst b/doc/source/core.rst index 4ef79a2..28bf1dc 100644 --- a/doc/source/core.rst +++ b/doc/source/core.rst @@ -68,10 +68,3 @@ properly tracked. Note that the change will directly enter the gate pipeline if and only if it has already a +1 vote from Zuul, otherwise it will first enter the check pipeline like a "recheck" would. - -When re-approving, core reviewers may need to work around a specific set -of Gerrit behavior. Gerrit only emits vote values in its event stream -when a reviewer's vote values change. This means that if a core reviewer -has already voted +1 Approved in the workflow category they will need -to leave a comment of +0 in the workflow category then re-approve with -a new +1 Approved comment.