opendev/infra-specs
Code Issues Proposed changes

Use Change-Id instead of URL for dependent patches

Browse Source 
This allows to get interdependent patches ready before submitting the
patches for review.

Change-Id is known locally, while gerrit URL only becomes available
after patch is submitted, requiring patch resubmission.

Change-Id: I3cb61c7dc08bb50c8c0dba92429af056af11ac94
This commit is contained in:
Mikhail S Medvedev
2014-11-25 10:43:11 -06:00
parent c2a9ef4d1b
commit be7692d6bc
1 changed files with 11 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
specs/puppet-modules.rst
View File

@@ -103,27 +103,31 @@ The following process must be done for each module separately:
#. Add a new gerrit project for the module in project-config (using the temporary project as upstream) #. Add a new gerrit project for the module in project-config (using the temporary project as upstream)
* Follow example here: https://review.openstack.org/#/c/131302/ * Follow example here: https://review.openstack.org/#/c/131302/
* Amend the commit message with a reference to system-config patch from
the next step.
::
"Needed-By: <system-config patch Change-Id>"
* Once this patch merges, the project in the temporary repo will be pulled into -infra. e.g. * Once this patch merges, the project in the temporary repo will be pulled into -infra. e.g.
http://git.openstack.org/cgit/openstack-infra/puppet-$MODULE/ http://git.openstack.org/cgit/openstack-infra/puppet-$MODULE/
#. Modify system-config/modules.env to install the module from the new gerrit project #. Modify system-config/modules.env to install the module from the new gerrit project
and add the new project to the puppet integration tests. Remove the old module and add the new project to the puppet integration tests. Remove the old module
from openstack_infra/config with rm. from openstack_infra/config with rm.
* We should continuously deploy the master branch * We should continuously deploy the master branch
* Include in commit message a reference to the project-config patch done in * Include in commit message a reference to the project-config patch done in
previous step previous step
:: ::
"Depends-On: <project-config patch url>" "Depends-On: <project-config patch Change-Id>"
* Update the project-config commit message done in previous step with a
reference to this system-config patch
::
"Needed-By: <system-config patch url>"
* Follow example here: https://review.openstack.org/#/c/131305/ * Follow example here: https://review.openstack.org/#/c/131305/