From c3a621900f9672b8e42b7e0dd969016936a49c8a Mon Sep 17 00:00:00 2001 From: Ramy Asselin Date: Wed, 13 Jan 2016 16:49:53 -0800 Subject: [PATCH] Only expire open reviews Closed, Merged, Abandoned reviews don't need to be re-expired. Only consider patches that are 'open'. Change-Id: I848a7949a00ef700c1687493a6bd26a7a9508cfd --- jeepyb/cmd/expire_old_reviews.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/jeepyb/cmd/expire_old_reviews.py b/jeepyb/cmd/expire_old_reviews.py index 9ec1064..5a62c05 100644 --- a/jeepyb/cmd/expire_old_reviews.py +++ b/jeepyb/cmd/expire_old_reviews.py @@ -74,7 +74,7 @@ def main(): for line in stdout: row = json.loads(line) - if 'rowCount' not in row: + if 'rowCount' not in row and 'open' in row and row['open']: # Search for negative approvals for approval in row['currentPatchSet']['approvals']: if approval['value'] in ('-1', '-2'):