Add Gemfile and puppet 4 checks

In anticipation of puppet 4, start trying to deal with puppet 4 things
that can be helpfully predicted by puppet lint plugins.

This patch also corrects errors caught by the
puppet-lint-empty_string-check gem. It makes the
$bugdaystats::site::configfile and $bugdaystats::site::httproot
parameters required since the file resources named after them could not
possibly work if they were left undefined or empty string. The
parameter $bugdaystats::site::serveradmin is currently unused in this
module, so we make it optional and default to undef in preparation for
when this functionality is added.

Change-Id: I9eef9a8d49c1ca597783b19fbbbe0129c6157cd5
This commit is contained in:
Colleen Murphy 2015-07-14 19:54:16 -07:00
parent a3240a7c5a
commit 0404830aca
3 changed files with 36 additions and 3 deletions

2
.gitignore vendored Normal file
View File

@ -0,0 +1,2 @@
Gemfile.lock
.bundled_gems/

31
Gemfile Normal file
View File

@ -0,0 +1,31 @@
source 'https://rubygems.org'
group :development, :test do
gem 'puppetlabs_spec_helper', :require => false
gem 'metadata-json-lint'
# This is nice and all, but let's not worry about it until we've actually
# got puppet 4.x sorted
# gem 'puppet-lint-param-docs'
gem 'puppet-lint-absolute_classname-check'
gem 'puppet-lint-absolute_template_path'
gem 'puppet-lint-trailing_newline-check'
# Puppet 4.x related lint checks
gem 'puppet-lint-unquoted_string-check'
gem 'puppet-lint-empty_string-check'
gem 'puppet-lint-leading_zero-check'
gem 'puppet-lint-variable_contains_upcase'
gem 'puppet-lint-numericvariable'
gem 'puppet-lint-spaceship_operator_without_tag-check'
gem 'puppet-lint-undef_in_function-check'
if puppetversion = ENV['PUPPET_GEM_VERSION']
gem 'puppet', puppetversion, :require => false
else
gem 'puppet', '~> 3.0', :require => false
end
end
# vim:ft=ruby

View File

@ -15,10 +15,10 @@
# == Define: bugdaystats
#
define bugdaystats::site(
$configfile,
$httproot,
$git_url = 'https://git.openstack.org/openstack-infra/bugdaystats',
$configfile = '',
$httproot = '',
$serveradmin = ''
$serveradmin = undef
) {
file { $configfile:
mode => '0444',