opendev/puppet-ethercalc
Code Issues Proposed changes

Don't use npm list --parseable

Browse Source 
Turns out we lose version info with --parseable (so not sure in what
world this is parseable output) so stop using the --parseable flag. This
corrects behavior where we reinstall ethercalc every puppet run which
can upgrade unpinned dep libs in ways that break them on older node (we
are using the ethercalc prescribed node but its a little old).

Change-Id: Ib9aebecf3a0c36c50e5069b1a871886e4ddb1a42
This commit is contained in:
Clark Boylan 2017-02-13 17:44:43 -08:00
parent 521672bc35
commit 4034168e71
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
manifests/init.pp
View File

@ -69,7 +69,7 @@ class ethercalc (
exec { 'install-ethercalc': exec { 'install-ethercalc':
command => "npm install ethercalc@${ethercalc_version}", command => "npm install ethercalc@${ethercalc_version}",
unless => "npm ls --parseable | grep ethercalc@${ethercalc_version}", unless => "npm ls | grep ethercalc@${ethercalc_version}",
path => $path, path => $path,
cwd => $base_install_dir, cwd => $base_install_dir,
require => Anchor['nodejs-anchor'], require => Anchor['nodejs-anchor'],