c66103ed4e
Patch Set 15: (1 comment) Patch-set: 15 Label: Verified=0
39 lines
1.2 KiB
Plaintext
39 lines
1.2 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"key": {
|
|
"uuid": "df87a7cf_eb9374ff",
|
|
"filename": "templates/ethercalc.service.erb",
|
|
"patchSetId": 15
|
|
},
|
|
"lineNbr": 11,
|
|
"author": {
|
|
"id": 13252
|
|
},
|
|
"writtenOn": "2017-12-14T09:34:53Z",
|
|
"side": 1,
|
|
"message": "Wouldn\u0027t that need to be \"\u003c%\u003d @ethercalc_user %\u003e\", i.e. add \"\u003d\"?\n\nAlso not sure why we don\u0027t hardcode to \"ethercalc\" when we hardcode the service name anyway.",
|
|
"revId": "f2b89f46c24a73bc1ad8e2cbaa64e2a5769710c5",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "df87a7cf_6d6c4508",
|
|
"filename": "templates/ethercalc.service.erb",
|
|
"patchSetId": 15
|
|
},
|
|
"lineNbr": 11,
|
|
"author": {
|
|
"id": 7118
|
|
},
|
|
"writtenOn": "2017-12-14T22:44:42Z",
|
|
"side": 1,
|
|
"message": "yeah, let\u0027s hardcode to avoid this",
|
|
"parentUuid": "df87a7cf_eb9374ff",
|
|
"revId": "f2b89f46c24a73bc1ad8e2cbaa64e2a5769710c5",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
}
|
|
]
|
|
} |