opendev/puppet-gerrit
Code Issues Proposed changes

Clean up of minor puppet-lint warnings.

Browse Source 
Mostly documentation and parameterised class parameter complaints.

Change-Id: Idbfd348a5befb041ce6eb36f9c6b195fc0c6799f
Reviewed-on: https://review.openstack.org/16685
Reviewed-by: Jeremy Stanley <fungi@yuggoth.org>
Approved: Monty Taylor <mordred@inaugust.com>
Reviewed-by: Monty Taylor <mordred@inaugust.com>
Tested-by: Jenkins
This commit is contained in:
Matthew Wagoner
2012-11-21 14:53:55 -05:00
committed by Jenkins
parent 13591dc2f3
commit ee35bb5fd8
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
manifests/init.pp
View File

@@ -67,10 +67,10 @@
# TODO: make more gerrit options configurable here # TODO: make more gerrit options configurable here
class gerrit( class gerrit(
$war, $war = '',
$mysql_password, $mysql_password = '',
$mysql_root_password, $mysql_root_password = '',
$email_private_key, $email_private_key = '',
$vhost_name = $::fqdn, $vhost_name = $::fqdn,
$canonicalweburl = "https://${::fqdn}/", $canonicalweburl = "https://${::fqdn}/",
$serveradmin = "webmaster@${::fqdn}", $serveradmin = "webmaster@${::fqdn}",
@@ -84,8 +84,8 @@ class gerrit(
$ssh_dsa_pubkey_contents = '', # If left empty puppet will not create file. $ssh_dsa_pubkey_contents = '', # If left empty puppet will not create file.
$ssh_rsa_key_contents = '', # If left empty puppet will not create file. $ssh_rsa_key_contents = '', # If left empty puppet will not create file.
$ssh_rsa_pubkey_contents = '', # If left empty puppet will not create file. $ssh_rsa_pubkey_contents = '', # If left empty puppet will not create file.
$ssh_project_rsa_key_contents = '', # If left empty puppet will not create file. $ssh_project_rsa_key_contents = '', # If left empty will not create file.
$ssh_project_rsa_pubkey_contents = '', # If left empty puppet will not create file. $ssh_project_rsa_pubkey_contents = '', # If left empty will not create file.
$openidssourl = 'https://login.launchpad.net/+openid', $openidssourl = 'https://login.launchpad.net/+openid',
$email = '', $email = '',
$database_poollimit = '', $database_poollimit = '',
@@ -367,7 +367,7 @@ class gerrit(
owner => 'gerrit2', owner => 'gerrit2',
group => 'gerrit2', group => 'gerrit2',
mode => '0644', mode => '0644',
content => $ssh_rsa_project_pubkey_contents, content => $ssh_project_rsa_pubkey_contents,
replace => true, replace => true,
require => File['/home/gerrit2/review_site/etc'] require => File['/home/gerrit2/review_site/etc']
} }