Clean up of minor puppet-lint warnings.

Mostly documentation and parameterised class parameter complaints.

Change-Id: I5b3ffa4ad3f707f385165c2d86c891c6bd4c1ae0
Reviewed-on: https://review.openstack.org/16901
Reviewed-by: James E. Blair <corvus@inaugust.com>
Approved: Clark Boylan <clark.boylan@gmail.com>
Reviewed-by: Clark Boylan <clark.boylan@gmail.com>
Tested-by: Jenkins

manifests/init.pp

@@ -1,16 +1,18 @@
+# == Class: gerritbot
+#
 class gerritbot(
-  $nick,
+  $nick = '',
-  $password,
+  $password = '',
-  $server,
+  $server = '',
-  $user,
+  $user = '',
-  $vhost_name
+  $vhost_name = ''
 ) {
   include pip
 
   package { 'gerritbot':
     ensure   => present,  # Pip upgrade is not working
     provider => pip,
-    require  => Class['pip']
+    require  => Class['pip'],
   }
 
   file { '/etc/init.d/gerritbot':
@@ -30,7 +32,7 @@ class gerritbot(
     subscribe  => [
       Package['gerritbot'],
       File['/etc/gerritbot/gerritbot.config'],
-      File['/etc/gerritbot/channel_config.yaml']
+      File['/etc/gerritbot/channel_config.yaml'],
     ],
   }