opendev/puppet-gerritbot
Code Issues Proposed changes

Update patch set 1

Browse Source 
Patch Set 1: Workflow-1

(2 comments)

Patch-set: 1
Reviewer: Gerrit User 5263 <5263@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Workflow=-1
This commit is contained in:
Gerrit User 5263 2018-10-05 17:24:57 +00:00 committed by Gerrit Code Review
parent 90eb42a8f4
commit f171627533
2 changed files with 42 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
2818d122ea0efd8af1899751a1b9620f947ed318 Normal file
View File

@ -0,0 +1,21 @@
{
"comments": [
{
"key": {
"uuid": "3f79a3b5_d73661b4",
"filename": "templates/gerritbot.config.erb",
"patchSetId": 1
},
"lineNbr": 5,
"author": {
"id": 5263
},
"writtenOn": "2018-10-05T17:24:57Z",
"side": 0,
"message": "Actually, we can\u0027t just remove this as the bot unconditionally attempts to retrieve this from the config and doesn\u0027t make use of the default set for the bot class.",
"revId": "2818d122ea0efd8af1899751a1b9620f947ed318",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}

21
4dccf8eea4064b32d849052ef3508a093c580a0c Normal file
View File

@ -0,0 +1,21 @@
{
"comments": [
{
"key": {
"uuid": "3f79a3b5_b73165be",
"filename": "/COMMIT_MSG",
"patchSetId": 1
},
"lineNbr": 9,
"author": {
"id": 5263
},
"writtenOn": "2018-10-05T17:24:57Z",
"side": 1,
"message": "Clearly cut-n-paste error, should have been s/statusbot/gerritbot/ here.",
"revId": "4dccf8eea4064b32d849052ef3508a093c580a0c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}