From ecb701836261609f82116c7e3e86ccb4d34527a7 Mon Sep 17 00:00:00 2001 From: Colleen Murphy Date: Thu, 23 Jul 2015 16:21:47 -0700 Subject: [PATCH] Fix class parameters Values for the username, oauth_token, project_username, and project_password parameters must be provided by the user. The empty string is not a sane default and will cause broken deployments if used. This change makes these parameters required. Infra is providing these parameters in system-config so this change will not break Infra. If downstream users are not providing these parameters their deployments will not be functional, so this change should be safe for users already using this class correctly. The use of the projects parameter was removed in 15daf9a so it no longer needs to be part of the parameter list. Infra is no longer using the projects parameter in system-config so this change will not break Infra. If downstream users still have this parameter as part of their manifest, updating the module to this commit will break their puppet runs, but not make any system changes. Change-Id: Ic7d42f922ae436fe1b7b9bef21ca659ddedae432 --- manifests/init.pp | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/manifests/init.pp b/manifests/init.pp index e634314..b08d570 100644 --- a/manifests/init.pp +++ b/manifests/init.pp @@ -1,11 +1,10 @@ # == Class: github # class github( - $username = '', - $oauth_token = '', - $project_username = '', - $project_password = '', - $projects = [] + $username, + $oauth_token, + $project_username, + $project_password, ) { include jeepyb include pip