From 5bc4dbc6c6aa45d5799982f5fde003149ae872f7 Mon Sep 17 00:00:00 2001
From: Colleen Murphy <colleen@gazlene.net>
Date: Wed, 22 Jul 2015 21:36:09 -0700
Subject: [PATCH] Make username/email/password params required

Values for the graphite_admin_username, graphite_admin_email, and
graphite_admin_password parameters must be provided by the user. The
empty string is not a sane default and will cause broken deployments if
used. This change makes these parameters required. Infra is providing
these parameters in system-config so this change will not break Infra.
If downstream users are not providing these parameters their
deployments will not be functional, so this change should be safe for
users already using this class correctly.

Change-Id: I7aed54bb09e54dc8c0827188adf971b76649f94d
---
 manifests/init.pp | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/manifests/init.pp b/manifests/init.pp
index 3adeaa6..8236d17 100644
--- a/manifests/init.pp
+++ b/manifests/init.pp
@@ -1,10 +1,10 @@
 # == Class: graphite
 #
 class graphite(
+  $graphite_admin_user,
+  $graphite_admin_email,
+  $graphite_admin_password,
   $vhost_name = $::fqdn,
-  $graphite_admin_user = '',
-  $graphite_admin_email = '',
-  $graphite_admin_password = '',
   $storage_schemas = [
     {
       'name'       => 'carbon',