opendev/puppet-jeepyb
Code Issues Proposed changes

Fix parameters for jeepyb::openstackwatch

Browse Source 
The swift_username, swift_password, swift_auth_url, and json_url
parameters all must be specified in order to work correctly, a default
value of empty string will cause brokenness. This patch removes the
default values for those parameters so that puppet will warn the user
that these values are required.

For the auth_version parameter, a default value of 1.0 is a safe
potential guess, so we change the default value from empty string to
'1.0'.

The feed parameter is no longer used as of
fdc8fd45bb26a8833662630c25b87b68d1e0ac12, so we remove it.

Change-Id: I0a10c0df80cb6a74e7bcc17d96e27e62373c61ff
Depends-On: Ie3c4f5184445b4653997c091279f21a3e9503b84
This commit is contained in:
Colleen Murphy 2015-08-03 18:29:00 -07:00
parent b1110c8db0
commit 0563885683
1 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
manifests/openstackwatch.pp
View File

@ -1,15 +1,14 @@
# == Class: jeepyb::openstackwatch
class jeepyb::openstackwatch(
$swift_username = '',
$swift_password = '',
$swift_auth_url = '',
$auth_version = '',
$swift_username,
$swift_password,
$swift_auth_url,
$json_url,
$auth_version = '1.0',
$projects = [],
$mode = 'multiple',
$container = 'rss',
$feed = '',
$json_url = '',
$minute = '18',
$hour = '*',
) {