opendev/puppet-jenkins
Code Issues Proposed changes

Require ssh_key, username, password and url

Browse Source 
Default these values to '' does provide any real value. We should
force the user to setup something other then an empty string.

Change-Id: I04da6afae5d39a20f9601b0dbd834e97d280d028
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
This commit is contained in:
Paul Belanger 2015-08-05 13:16:35 -04:00
parent 58569fe338
commit 3651901d10
3 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
manifests/jenkinsuser.pp
View File

@ -1,7 +1,7 @@
# == Class: jenkins::jenkinsuser # == Class: jenkins::jenkinsuser
# #
class jenkins::jenkinsuser( class jenkins::jenkinsuser(
$ssh_key = '', $ssh_key,
$ensure = present, $ensure = present,
$gitfullname = 'OpenStack Jenkins', $gitfullname = 'OpenStack Jenkins',
$gitemail = 'jenkins@openstack.org', $gitemail = 'jenkins@openstack.org',

6
manifests/job_builder.pp
View File

@ -1,9 +1,9 @@
# == Class: jenkins::job_builder # == Class: jenkins::job_builder
# #
class jenkins::job_builder ( class jenkins::job_builder (
$url = '', $url,
$username = '', $username,
$password = '', $password,
$git_revision = 'master', $git_revision = 'master',
$git_url = 'https://git.openstack.org/openstack-infra/jenkins-job-builder', $git_url = 'https://git.openstack.org/openstack-infra/jenkins-job-builder',
$config_dir = '', $config_dir = '',

2
manifests/slave.pp
View File

@ -1,7 +1,7 @@
# == Class: jenkins::slave # == Class: jenkins::slave
# #
class jenkins::slave( class jenkins::slave(
$ssh_key = '', $ssh_key,
$user = true, $user = true,
$gitfullname = 'OpenStack Jenkins', $gitfullname = 'OpenStack Jenkins',
$gitemail = 'jenkins@openstack.org', $gitemail = 'jenkins@openstack.org',