Update patch set 10

Patch Set 10: (6 comments) Saving my comments. Will review more later. Patch-set: 10 Reviewer: Gerrit User 9624 <9624@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Verified=0
2017-05-12 18:23:12 +00:00 · 2017-05-12 18:23:12 +00:00 · 93d4daf444
parent 418eaa940d
commit 93d4daf444
2 changed files with 110 additions and 0 deletions
--- a/89
+++ b/89
@ -0,0 +1,89 @@
+{
+  "comments": [
+    {
+      "key": {
+        "uuid": "1f013ff3_2a5bdf2e",
+        "filename": "spec/acceptance/fixtures/master.pp",
+        "patchSetId": 10
+      },
+      "lineNbr": 3,
+      "author": {
+        "id": 9624
+      },
+      "writtenOn": "2017-05-12T18:23:12Z",
+      "side": 0,
+      "message": "I don\u0027t fully understand why you remove the jenkins user. \nIsn\u0027t this is still needed for older zuul/nodepool/jenkins integration?",
+      "revId": "b50710875063cfd7a879f987a0190e3978a04cbe",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "1f013ff3_ea0e1731",
+        "filename": "spec/acceptance/master_spec.rb",
+        "patchSetId": 10
+      },
+      "lineNbr": 46,
+      "author": {
+        "id": 9624
+      },
+      "writtenOn": "2017-05-12T18:23:12Z",
+      "side": 0,
+      "message": "Most of this removal is fine. The ssh key is nice to keep, but not really valuable to \u0027test\u0027, so OK to remove.",
+      "revId": "b50710875063cfd7a879f987a0190e3978a04cbe",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "1f013ff3_2a0d1f37",
+        "filename": "spec/acceptance/master_spec.rb",
+        "patchSetId": 10
+      },
+      "lineNbr": 80,
+      "author": {
+        "id": 9624
+      },
+      "writtenOn": "2017-05-12T18:23:12Z",
+      "side": 0,
+      "message": "ok to remove, testing service running is sufficient.",
+      "revId": "b50710875063cfd7a879f987a0190e3978a04cbe",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "1f013ff3_4a086b27",
+        "filename": "spec/acceptance/master_spec.rb",
+        "patchSetId": 10
+      },
+      "lineNbr": 98,
+      "author": {
+        "id": 9624
+      },
+      "writtenOn": "2017-05-12T18:23:12Z",
+      "side": 0,
+      "message": "ok to remove. Agree, if Jenkins is running, the required packages/users and groups are also there.",
+      "revId": "b50710875063cfd7a879f987a0190e3978a04cbe",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "1f013ff3_4a7d0b6d",
+        "filename": "spec/acceptance/slave_spec.rb",
+        "patchSetId": 10
+      },
+      "lineNbr": 32,
+      "author": {
+        "id": 9624
+      },
+      "writtenOn": "2017-05-12T18:23:12Z",
+      "side": 0,
+      "message": "Ok. This is bascially just restating puppet again.",
+      "revId": "b50710875063cfd7a879f987a0190e3978a04cbe",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    }
+  ]
+}
--- a/21
+++ b/21
@ -0,0 +1,21 @@
+{
+  "comments": [
+    {
+      "key": {
+        "uuid": "1f013ff3_2af75ff8",
+        "filename": "/COMMIT_MSG",
+        "patchSetId": 10
+      },
+      "lineNbr": 31,
+      "author": {
+        "id": 9624
+      },
+      "writtenOn": "2017-05-12T18:23:12Z",
+      "side": 1,
+      "message": "What was the error?",
+      "revId": "f5bc1cae64766279b44782f00f7b73ed715ebc2d",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    }
+  ]
+}