Update patch set 18

Patch Set 18: Code-Review-1

(3 comments)

-1 is for style. Fix it and I think this should go in.

I have checked for regressions and found only one possible problem: if anyone specifies 'puppet:///modules/jenkins/jenkins.default' as $jenkins_deafult, it would fail because the file is not there. But they should not have been doing that anyway.

Using template makes module more user-friendly (as opposed to asking to provide complete configuration file).

Patch-set: 18
Label: Code-Review=-1

f20dc945dd4d7347f787632b069a9ee8707d81ce

@@ -0,0 +1,73 @@
+{
+  "comments": [
+    {
+      "key": {
+        "uuid": "7a77a97e_ea03c1bc",
+        "filename": "manifests/master.pp",
+        "patchSetId": 18
+      },
+      "lineNbr": 174,
+      "author": {
+        "id": 7979
+      },
+      "writtenOn": "2016-11-21T14:11:46Z",
+      "side": 1,
+      "message": "Remove extra newline after the block, or use # in its place.",
+      "range": {
+        "startLine": 170,
+        "startChar": 0,
+        "endLine": 174,
+        "endChar": 16
+      },
+      "revId": "f20dc945dd4d7347f787632b069a9ee8707d81ce",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "7a77a97e_6adc1175",
+        "filename": "manifests/master.pp",
+        "patchSetId": 18
+      },
+      "lineNbr": 183,
+      "author": {
+        "id": 7979
+      },
+      "writtenOn": "2016-11-21T14:11:46Z",
+      "side": 1,
+      "message": "Can we use the \u0027jenkins/jenkins.default.erb\u0027 directly, without introducing extra variable?",
+      "range": {
+        "startLine": 183,
+        "startChar": 0,
+        "endLine": 183,
+        "endChar": 45
+      },
+      "revId": "f20dc945dd4d7347f787632b069a9ee8707d81ce",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "7a77a97e_6aaed1e8",
+        "filename": "manifests/master.pp",
+        "patchSetId": 18
+      },
+      "lineNbr": 186,
+      "author": {
+        "id": 7979
+      },
+      "writtenOn": "2016-11-21T14:11:46Z",
+      "side": 1,
+      "message": "Remove newline:\n   } else {",
+      "range": {
+        "startLine": 185,
+        "startChar": 0,
+        "endLine": 186,
+        "endChar": 8
+      },
+      "revId": "f20dc945dd4d7347f787632b069a9ee8707d81ce",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    }
+  ]
+}