57 lines
1.9 KiB
Plaintext
57 lines
1.9 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"key": {
|
|
"uuid": "fa69d971_ac50b95f",
|
|
"filename": "manifests/master.pp",
|
|
"patchSetId": 6
|
|
},
|
|
"lineNbr": 15,
|
|
"author": {
|
|
"id": 9624
|
|
},
|
|
"writtenOn": "2016-01-07T17:26:56Z",
|
|
"side": 1,
|
|
"message": "This is not being used anymore. Seems an erb should be passed in instead to be consistent with this change.",
|
|
"revId": "65898a6aa3f0931dac7359cf5232a214d3ae06f0",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "fa69d971_d26ca6d2",
|
|
"filename": "manifests/master.pp",
|
|
"patchSetId": 6
|
|
},
|
|
"lineNbr": 15,
|
|
"author": {
|
|
"id": 6133
|
|
},
|
|
"writtenOn": "2016-01-07T17:55:28Z",
|
|
"side": 1,
|
|
"message": "Good catch. @RamyAsselin, how this will affect to third party ci? Are you relying on this setting to override jenkins.default, passing an external file?",
|
|
"parentUuid": "fa69d971_ac50b95f",
|
|
"revId": "65898a6aa3f0931dac7359cf5232a214d3ae06f0",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "fa69d971_824a5954",
|
|
"filename": "manifests/master.pp",
|
|
"patchSetId": 6
|
|
},
|
|
"lineNbr": 15,
|
|
"author": {
|
|
"id": 9624
|
|
},
|
|
"writtenOn": "2016-01-07T18:58:53Z",
|
|
"side": 1,
|
|
"message": "@yolanda, no impact to 3rd party ci. \nThere are no users within openstack [1]\nBut seems you\u0027re the one who added the line, mentioning downstream users [2]\n\n[1] http://codesearch.openstack.org/?q\u003djenkins_default\u0026i\u003dnope\u0026files\u003d\u0026repos\u003d\n\n[2] https://review.openstack.org/#/c/211481/",
|
|
"parentUuid": "fa69d971_d26ca6d2",
|
|
"revId": "65898a6aa3f0931dac7359cf5232a214d3ae06f0",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
}
|
|
]
|
|
} |