89 lines
2.7 KiB
Plaintext
89 lines
2.7 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"key": {
|
|
"uuid": "3a57f1b5_13bf64fc",
|
|
"filename": "manifests/master.pp",
|
|
"patchSetId": 10
|
|
},
|
|
"lineNbr": 1,
|
|
"author": {
|
|
"id": 9624
|
|
},
|
|
"writtenOn": "2016-02-11T02:03:17Z",
|
|
"side": 1,
|
|
"message": "Let\u0027s using a puppet standard. I don\u0027t know where it is defined, but here\u0027s an example:\n\nhttp://git.openstack.org/cgit/openstack-infra/puppet-openstackci/tree/manifests/single_node_ci.pp#n16",
|
|
"revId": "c6ff2cd143782f7a35739d250253b18f98664cef",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "3a57f1b5_938274ff",
|
|
"filename": "manifests/master.pp",
|
|
"patchSetId": 10
|
|
},
|
|
"lineNbr": 27,
|
|
"author": {
|
|
"id": 9624
|
|
},
|
|
"writtenOn": "2016-02-11T02:03:17Z",
|
|
"side": 1,
|
|
"message": "it would be better if this was undef instead of \u0027\u0027",
|
|
"revId": "c6ff2cd143782f7a35739d250253b18f98664cef",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "9aed3d3a_ee2253a2",
|
|
"filename": "manifests/master.pp",
|
|
"patchSetId": 10
|
|
},
|
|
"lineNbr": 28,
|
|
"author": {
|
|
"id": 9624
|
|
},
|
|
"writtenOn": "2016-02-29T15:08:10Z",
|
|
"side": 1,
|
|
"message": "Let\u0027s make this a reference-able parameter that can be used in https://review.openstack.org/#/c/263021/7",
|
|
"revId": "c6ff2cd143782f7a35739d250253b18f98664cef",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "3a57f1b5_53e87ce2",
|
|
"filename": "manifests/master.pp",
|
|
"patchSetId": 10
|
|
},
|
|
"lineNbr": 147,
|
|
"author": {
|
|
"id": 9624
|
|
},
|
|
"writtenOn": "2016-02-11T02:03:17Z",
|
|
"side": 1,
|
|
"message": "This can be simplified by having the if else define the variable contents and use a single file {} block with contect \u003d\u003e template($new_var_for_template)",
|
|
"revId": "c6ff2cd143782f7a35739d250253b18f98664cef",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "3a57f1b5_7378182c",
|
|
"filename": "manifests/master.pp",
|
|
"patchSetId": 10
|
|
},
|
|
"lineNbr": 148,
|
|
"author": {
|
|
"id": 9624
|
|
},
|
|
"writtenOn": "2016-02-11T02:03:17Z",
|
|
"side": 1,
|
|
"message": "update to undef here",
|
|
"revId": "c6ff2cd143782f7a35739d250253b18f98664cef",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
}
|
|
]
|
|
} |