85 lines
2.8 KiB
Plaintext
85 lines
2.8 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"key": {
|
|
"uuid": "7a8ec9b2_133782ff",
|
|
"filename": "manifests/indexer.pp",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 92,
|
|
"author": {
|
|
"id": 7069
|
|
},
|
|
"writtenOn": "2016-09-18T16:04:39Z",
|
|
"side": 1,
|
|
"message": "This will execute every time. We should make this more idempotent.\n\nPerhaps checking if the file exists, but then how do you get new versions etc?",
|
|
"range": {
|
|
"startLine": 92,
|
|
"startChar": 6,
|
|
"endLine": 92,
|
|
"endChar": 12
|
|
},
|
|
"revId": "5a9ea735e84c9ecbb5e1f67b2ed57c214b397c9c",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "7a8ec9b2_d3e405ae",
|
|
"filename": "manifests/indexer.pp",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 92,
|
|
"author": {
|
|
"id": 8482
|
|
},
|
|
"writtenOn": "2016-09-19T18:27:02Z",
|
|
"side": 1,
|
|
"message": "++\n\nI interpret this as just install once, not ensure \u003d\u003e latest. If it needed to be kept updated it looks like \u0027plugin update\u0027 should be used in addition to \u0027plugin install\u0027. So to keep the exec from running every time, add an onlyif parameter with something like `onlyif \u003d\u003e /opt/logstash/bin/plugin list logstash-output-mqtt | grep logstash-output-mqtt`.",
|
|
"parentUuid": "7a8ec9b2_133782ff",
|
|
"range": {
|
|
"startLine": 92,
|
|
"startChar": 6,
|
|
"endLine": 92,
|
|
"endChar": 12
|
|
},
|
|
"revId": "5a9ea735e84c9ecbb5e1f67b2ed57c214b397c9c",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "7a8ec9b2_1362ed16",
|
|
"filename": "manifests/indexer.pp",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 98,
|
|
"author": {
|
|
"id": 8482
|
|
},
|
|
"writtenOn": "2016-09-19T18:27:02Z",
|
|
"side": 1,
|
|
"message": "true is the default, you don\u0027t need to specify it https://docs.puppet.com/puppet/latest/reference/type.html#file-attribute-replace",
|
|
"revId": "5a9ea735e84c9ecbb5e1f67b2ed57c214b397c9c",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "7a8ec9b2_5343956c",
|
|
"filename": "manifests/indexer.pp",
|
|
"patchSetId": 8
|
|
},
|
|
"lineNbr": 102,
|
|
"author": {
|
|
"id": 8482
|
|
},
|
|
"writtenOn": "2016-09-19T18:27:02Z",
|
|
"side": 1,
|
|
"message": "Do you want to use notify instead of before here? i.e. should the service restart if this file is changed?",
|
|
"revId": "5a9ea735e84c9ecbb5e1f67b2ed57c214b397c9c",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
}
|
|
]
|
|
} |