From ae79f7b8d4382878f2cea8da71e38f1727956e55 Mon Sep 17 00:00:00 2001 From: Colleen Murphy Date: Sun, 11 Jun 2017 21:16:13 +0200 Subject: [PATCH] Remove unnecessary beaker tests It is good enough to assume that if puppet finished successfully then it also successfully found and installed packages and applied configs. For the sake of maintainability, remove unnecessary tests. Change-Id: Iac783ddacfad7a58eca08635924e04da0016b625 --- spec/acceptance/frontend_spec.rb | 36 -------------------------------- 1 file changed, 36 deletions(-) diff --git a/spec/acceptance/frontend_spec.rb b/spec/acceptance/frontend_spec.rb index 822b0c1..5696587 100644 --- a/spec/acceptance/frontend_spec.rb +++ b/spec/acceptance/frontend_spec.rb @@ -15,42 +15,6 @@ describe 'puppet-openstack_health::api manifest', :if => ['debian', 'ubuntu'].in apply_manifest(frontend_puppet_module, catch_failures: true) end - describe 'required packages' do - describe 'os packages' do - required_packages = [ - package('apache2'), - package('nodejs'), - ] - - required_packages.each do |package| - describe package do - it { should be_installed } - end - end - end - - describe 'npm packages' do - required_packages = [ - package('node-gyp'), - package('gulp'), - ] - - required_packages.each do |package| - describe package do - it { should be_installed.by('npm') } - end - end - end - end - - describe 'required files' do - describe file('/opt/openstack-health') do - it { should be_directory } - it { should be_owned_by 'openstack_health' } - it { should be_grouped_into 'openstack_health' } - end - end - describe 'required services' do describe 'ports are open and services are reachable' do describe port(80) do