Update patch set 1

Patch Set 1:

(1 comment)

My 2 cents worth for future reference.

Patch-set: 1

4fad418135bf8272936dbca629c7fc2135526b58

@@ -0,0 +1,21 @@
+{
+  "comments": [
+    {
+      "key": {
+        "uuid": "3a29b11f_87ba316d",
+        "filename": "migrate-to-phab.sql",
+        "patchSetId": 1
+      },
+      "lineNbr": 144,
+      "author": {
+        "id": 16051
+      },
+      "writtenOn": "2015-10-20T13:56:11Z",
+      "side": 1,
+      "message": "By adding column names for inserts e.g. insert into user (col1, col2, col3, ...) it makes it infinitely easier to troubleshoot when the underlying table changes over time.  As there is no versioning recorded here, e.g. we are migrated from Storyboard V1.1.1 to Phabricator V2.2.2.\n\nAs seen below additional random values of 0, 0, 1, 1, NULL, NULL are necessary for the query to work, but have no meaning in both the context of looking at the entire SQL, or at the change.\n\nIt\u0027s a little bit of work, but it\u0027s infinitely more benefit in the lifetime of the work.  A great example is at https://github.com/ronaldbradford/puppet-phabricator/blob/master/migration/sql/migrate_users.sql",
+      "revId": "4fad418135bf8272936dbca629c7fc2135526b58",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    }
+  ]
+}