Update patch set 11

Patch Set 11: Code-Review-1

(4 comments)

Patch-set: 11
Reviewer: Gerrit User 6133 <6133@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1

9489bc2662bc4e8ab6094b6ea94d25e34c3d2328

@@ -0,0 +1,96 @@
+{
+  "comments": [
+    {
+      "key": {
+        "uuid": "bacf61ea_3140e406",
+        "filename": "manifests/httpd.pp",
+        "patchSetId": 11
+      },
+      "lineNbr": 41,
+      "author": {
+        "id": 6133
+      },
+      "writtenOn": "2016-08-02T07:16:04Z",
+      "side": 1,
+      "message": "a require httpd_docroot shall be needed there?",
+      "range": {
+        "startLine": 41,
+        "startChar": 4,
+        "endLine": 41,
+        "endChar": 11
+      },
+      "revId": "9489bc2662bc4e8ab6094b6ea94d25e34c3d2328",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "bacf61ea_51491830",
+        "filename": "manifests/init.pp",
+        "patchSetId": 11
+      },
+      "lineNbr": 66,
+      "author": {
+        "id": 6133
+      },
+      "writtenOn": "2016-08-02T07:16:04Z",
+      "side": 1,
+      "message": "why that before here, and not requiring the phabricator::vars in the other classes?",
+      "range": {
+        "startLine": 66,
+        "startChar": 4,
+        "endLine": 66,
+        "endChar": 10
+      },
+      "revId": "9489bc2662bc4e8ab6094b6ea94d25e34c3d2328",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "bacf61ea_d16348af",
+        "filename": "manifests/install.pp",
+        "patchSetId": 11
+      },
+      "lineNbr": 30,
+      "author": {
+        "id": 6133
+      },
+      "writtenOn": "2016-08-02T07:16:04Z",
+      "side": 1,
+      "message": "why these packages are not under if ! defined, and some others are?",
+      "range": {
+        "startLine": 30,
+        "startChar": 2,
+        "endLine": 30,
+        "endChar": 9
+      },
+      "revId": "9489bc2662bc4e8ab6094b6ea94d25e34c3d2328",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "bacf61ea_511e380c",
+        "filename": "templates/set-auth_providerconfig.sql.erb",
+        "patchSetId": 11
+      },
+      "lineNbr": 1,
+      "author": {
+        "id": 6133
+      },
+      "writtenOn": "2016-08-02T07:16:04Z",
+      "side": 1,
+      "message": "why is that a template, if no var is replaced? is that for a future need?",
+      "range": {
+        "startLine": 1,
+        "startChar": 0,
+        "endLine": 1,
+        "endChar": 6
+      },
+      "revId": "9489bc2662bc4e8ab6094b6ea94d25e34c3d2328",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    }
+  ]
+}