opendev
/
puppet-phabricator
Code Issues Proposed changes

Update patch set 6 

Patch Set 6:

(2 comments)

Patch-set: 6
This commit is contained in:
Gerrit User 12767 2016-03-09 18:56:57 +00:00 committed by Gerrit Code Review
parent ac5f5bb1d8
commit 55b7d7faf9
1 changed files with 34 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
048cf6854041fe818262202bae7a7de796594448
View File

@ -69,6 +69,23 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5aef4532_33c6579a",
"filename": "manifests/default.pp",
"patchSetId": 6
},
"lineNbr": 64,
"author": {
"id": 12767
},
"writtenOn": "2016-03-09T18:56:57Z",
"side": 1,
"message": "I agree Ricardo. This a file I inherited and is only ever going to be used on my dev instances. In prod these classes are being split out as recommended.",
"revId": "048cf6854041fe818262202bae7a7de796594448",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9aed3d3a_0ea59303",
@ -120,6 +137,23 @@
"revId": "048cf6854041fe818262202bae7a7de796594448",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5aef4532_13c35b8a",
"filename": "manifests/default.pp",
"patchSetId": 6
},
"lineNbr": 129,
"author": {
"id": 12767
},
"writtenOn": "2016-03-09T18:56:57Z",
"side": 1,
"message": "Thanks Ricardo. Great reference.",
"revId": "048cf6854041fe818262202bae7a7de796594448",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}