opendev
/
puppet-phabricator
Code Issues Proposed changes

Update patch set 6 

Patch Set 6: Code-Review-1

(2 comments)

the linter is not happy with you :)

Patch-set: 6
Reviewer: Gerrit User 6987 <6987@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1
This commit is contained in:
Gerrit User 6987 2016-02-25 18:04:55 +00:00 committed by Gerrit Code Review
parent 793c3fd143
commit eac1d2649a
1 changed files with 38 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
048cf6854041fe818262202bae7a7de796594448 Normal file
View File

@ -0,0 +1,38 @@
{
"comments": [
{
"key": {
"uuid": "9aed3d3a_b393304f",
"filename": "manifests/default.pp",
"patchSetId": 6
},
"lineNbr": 5,
"author": {
"id": 6987
},
"writtenOn": "2016-02-25T18:04:55Z",
"side": 1,
"message": "wondering why is phabricator at root level? aren\u0027t apps usually in /opt?",
"revId": "048cf6854041fe818262202bae7a7de796594448",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9aed3d3a_0ea59303",
"filename": "manifests/default.pp",
"patchSetId": 6
},
"lineNbr": 129,
"author": {
"id": 6987
},
"writtenOn": "2016-02-25T18:04:55Z",
"side": 1,
"message": "Is this some trick? I wasn\u0027t aware that puppet allows running in sequence like this. I thought you had to order steps using notify, require and subscribe?",
"revId": "048cf6854041fe818262202bae7a7de796594448",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}