opendev
/
puppet-refstack
Code Issues Proposed changes

Use versioncmp function 

Puppet 4 is more strict about data types and doesn't tolerate using
arithmetic operators on strings. The operatingsystemrelease fact is a
string. Switch the arithmetic comparison to a native function that knows
how to deal with version numbers.

Change-Id: I63b0ffaba89d609a8107235759653be415820d7c
This commit is contained in:
Colleen Murphy 2018-04-26 21:39:50 +02:00
parent e22ef04d4f
commit 013781cb46
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
manifests/params.pp
View File

@ -46,7 +46,7 @@ class refstack::params (
) {
# Resolve a few parameters based on the install environment.
if $::operatingsystem != 'Ubuntu' or $::operatingsystemrelease < 13.10 {
if $::operatingsystem != 'Ubuntu' or versioncmp($::operatingsystemrelease, '13.10') < 0 {
fail("${::operatingsystem} ${::operatingsystemrelease} is not supported.")
}