Update patch set 1

Browse Source

Patch Set 1: Workflow-1

> I think we were doing this to ensure that permissions are correct
 > on the git repo. Maybe we can require the vcsrepo resource from the
 > file resource to order them explicitly? This way git repo is
 > created then permissions and ownership are applied?

Oh, that's a good point. But actually vcsrepo can set the owner and group itself, so we can try using that: 

http://git.openstack.org/cgit/openstack-infra/puppet-vcsrepo/tree/lib/puppet/type/vcsrepo.rb#n132

and I think the 755 mode would be default unless there's some umask set?

Patch-set: 1
Reviewer: Gerrit User 8482 <8482@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Workflow=-1

...

This commit is contained in:

Gerrit User 8482 2018-07-18 07:08:48 +00:00 committed by Gerrit Code Review

parent 5ce54a252e

commit 1bd6ac48fd

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Show Stats Download Patch File Download Diff File Expand all files Collapse all files

Diff Content Not Available