From 515d3dbe03ba8da957a3c749433c258fde4f1cd4 Mon Sep 17 00:00:00 2001 From: Gerrit User 6133 <6133@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Date: Tue, 27 Oct 2015 23:22:13 +0000 Subject: [PATCH] Update patch set 21 Patch Set 21: Code-Review-1 (3 comments) Patch-set: 21 Label: Code-Review=-1 --- 32ad3fccbcd153ccced6237a415d7bba8a8ae33e | 55 ++++++++++++++++++++++++ 1 file changed, 55 insertions(+) create mode 100644 32ad3fccbcd153ccced6237a415d7bba8a8ae33e diff --git a/32ad3fccbcd153ccced6237a415d7bba8a8ae33e b/32ad3fccbcd153ccced6237a415d7bba8a8ae33e new file mode 100644 index 0000000..43b3f13 --- /dev/null +++ b/32ad3fccbcd153ccced6237a415d7bba8a8ae33e @@ -0,0 +1,55 @@ +{ + "comments": [ + { + "key": { + "uuid": "1a26ad4f_716361b2", + "filename": "manifests/init.pp", + "patchSetId": 21 + }, + "lineNbr": 162, + "author": { + "id": 6133 + }, + "writtenOn": "2015-10-27T23:22:13Z", + "side": 1, + "message": "you need to use httpd::mod now", + "revId": "32ad3fccbcd153ccced6237a415d7bba8a8ae33e", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + }, + { + "key": { + "uuid": "1a26ad4f_1158edf9", + "filename": "templates/stackalytics.vhost.erb", + "patchSetId": 21 + }, + "lineNbr": 9, + "author": { + "id": 6133 + }, + "writtenOn": "2015-10-27T23:22:13Z", + "side": 1, + "message": "this will work only for apache 2.4 or greater, do we want to limit the module to these versions?", + "revId": "32ad3fccbcd153ccced6237a415d7bba8a8ae33e", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + }, + { + "key": { + "uuid": "1a26ad4f_510505c0", + "filename": "templates/uwsgi.ini.erb", + "patchSetId": 21 + }, + "lineNbr": 9, + "author": { + "id": 6133 + }, + "writtenOn": "2015-10-27T23:22:13Z", + "side": 1, + "message": "why is that a template if it has no placeholders to replace? if not needed, it should be a file", + "revId": "32ad3fccbcd153ccced6237a415d7bba8a8ae33e", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + } + ] +} \ No newline at end of file