puppet-stackalytics/d8ce3a76860654bf1ee8e22424fd312670bf6ed3
Gerrit User 5950 6cd2ee6781 Update patch set 7
Patch Set 7:

(2 comments)

Patch-set: 7
Label: Verified=0
2015-06-24 15:37:06 +00:00

106 lines
3.2 KiB
Plaintext

{
"comments": [
{
"key": {
"uuid": "fa32b979_cde315a3",
"filename": "manifests/init.pp",
"patchSetId": 7
},
"lineNbr": 38,
"author": {
"id": 5950
},
"writtenOn": "2015-06-24T15:37:06Z",
"side": 1,
"message": "current requirement is about 2.5Gb and it increases on approx 0.5Gb per year",
"revId": "d8ce3a76860654bf1ee8e22424fd312670bf6ed3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "fa32b979_5fd9fd55",
"filename": "manifests/init.pp",
"patchSetId": 7
},
"lineNbr": 101,
"author": {
"id": 6133
},
"writtenOn": "2015-06-24T10:42:55Z",
"side": 1,
"message": "to improve downstream consumption, i\u0027d prefer to parameterize that bit",
"revId": "d8ce3a76860654bf1ee8e22424fd312670bf6ed3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "fa32b979_0dc7bd96",
"filename": "templates/stackalytics.conf.erb",
"patchSetId": 7
},
"lineNbr": 1,
"author": {
"id": 5950
},
"writtenOn": "2015-06-24T15:37:06Z",
"side": 1,
"message": "use the latest version as baseline - https://review.openstack.org/gitweb?p\u003dstackforge/stackalytics.git;a\u003dblob;f\u003detc/stackalytics.conf;h\u003de74be5197850409dcf332f95d3a90f4401e32bc5;hb\u003dHEAD",
"revId": "d8ce3a76860654bf1ee8e22424fd312670bf6ed3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "fa32b979_dfcc2d8b",
"filename": "templates/stackalytics.conf.erb",
"patchSetId": 7
},
"lineNbr": 45,
"author": {
"id": 6133
},
"writtenOn": "2015-06-24T10:42:55Z",
"side": 1,
"message": "can this be parameterized as well?",
"revId": "d8ce3a76860654bf1ee8e22424fd312670bf6ed3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "fa32b979_1f84d508",
"filename": "templates/stackalytics.vhost.erb",
"patchSetId": 7
},
"lineNbr": 1,
"author": {
"id": 6133
},
"writtenOn": "2015-06-24T10:42:55Z",
"side": 1,
"message": "why using scope.lookupvar and not just @vhost_name here? maybe prefix vars with stackalytics_vhost_name if you are worried about some duplication",
"revId": "d8ce3a76860654bf1ee8e22424fd312670bf6ed3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "fa32b979_bf7da91d",
"filename": "templates/uwsgi.ini.erb",
"patchSetId": 7
},
"lineNbr": 7,
"author": {
"id": 6133
},
"writtenOn": "2015-06-24T10:42:55Z",
"side": 1,
"message": "can we parameterize processes and threads?",
"revId": "d8ce3a76860654bf1ee8e22424fd312670bf6ed3",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}