Update patch set 4

Patch Set 4:

(1 comment)

Patch-set: 4
Attention: {"person_ident":"Gerrit User 9311 \u003c9311@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"Tristan Cacqueray replied on the change"}
Attention: {"person_ident":"Gerrit User 5263 \u003c5263@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"Tristan Cacqueray replied on the change"}
This commit is contained in:
Gerrit User 9311 2021-11-10 19:28:18 +00:00 committed by Gerrit Code Review
parent fe05788987
commit 3125beeaf1
1 changed files with 18 additions and 0 deletions

View File

@ -51,6 +51,24 @@
"message": "Nah, this is fine, I just wasn\u0027t sure if the point of this function was to guard against a missing section raising configparser.NoSectionError but now that I play with it a bit more I see that a missing option even raises configparser.NoOptionError as well. However the entire function could simply be:\n\n return config.get(section, name, fallback\u003dNone)\n\nThe fallback keyword argument seems to be sufficient to avoid both exceptions. This probably makes the convenience wrapper itself a questionable bit of added complexity.",
"revId": "ffa9604027820982f700701359f68f151efbc317",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "be3df733_fd5af305",
"filename": "statusbot/bot.py",
"patchSetId": 3
},
"lineNbr": 134,
"author": {
"id": 9311
},
"writtenOn": "2021-11-10T19:28:18Z",
"side": 1,
"message": "Thank you for the suggestion, I didn\u0027t knew about the fallback argument. I\u0027ve update the call sites and removed the wrapper.",
"parentUuid": "c40e8adc_f839ba4f",
"revId": "ffa9604027820982f700701359f68f151efbc317",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}