opendev
/
statusbot
Code Issues Proposed changes

Update patch set 3 

Patch Set 3: Code-Review+2

(3 comments)

Patch-set: 3
Reviewer: Gerrit User 4146 <4146@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+2
This commit is contained in:
Gerrit User 4146 2017-03-20 22:08:23 +00:00 committed by Gerrit Code Review
parent cf83d79702
commit 406fbad597
1 changed files with 55 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

55
3bb38cc92bef2f697b2276dc85aa01cdaf4c01bb Normal file
View File

@ -0,0 +1,55 @@
{
"comments": [
{
"key": {
"uuid": "1a1ced50_75f4a2f1",
"filename": "statusbot/bot.py",
"patchSetId": 3
},
"lineNbr": 170,
"author": {
"id": 4146
},
"writtenOn": "2017-03-20T22:08:23Z",
"side": 1,
"message": "We don\u0027t have an explicit import for logging but it gets pulled in via the import for logging.config. If we end up needing a new patchset for this might be nice to add the explicit import to make this more robust against refactors that may remove logging.config usage or something like that.",
"revId": "3bb38cc92bef2f697b2276dc85aa01cdaf4c01bb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1a1ced50_b5737a7f",
"filename": "statusbot/bot.py",
"patchSetId": 3
},
"lineNbr": 181,
"author": {
"id": 4146
},
"writtenOn": "2017-03-20T22:08:23Z",
"side": 1,
"message": "Might help if instead of msg being logged here we logged tweets[0] so that the specific content that failed is logged. Less important here where msg \u003d\u003d tweets[0] but in the else case below I could see how that is useful.",
"revId": "3bb38cc92bef2f697b2276dc85aa01cdaf4c01bb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1a1ced50_1569ae8b",
"filename": "statusbot/bot.py",
"patchSetId": 3
},
"lineNbr": 189,
"author": {
"id": 4146
},
"writtenOn": "2017-03-20T22:08:23Z",
"side": 1,
"message": "See above.",
"revId": "3bb38cc92bef2f697b2276dc85aa01cdaf4c01bb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}