opendev
/
statusbot
Code Issues Proposed changes

Update patch set 3 

Patch Set 3:

(1 comment)

Patch-set: 3
Attention: {"person_ident":"Gerrit User 9311 \u003c9311@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"Someone else replied on the change"}
This commit is contained in:
Gerrit User 5263 2021-11-10 17:44:12 +00:00 committed by Gerrit Code Review
parent 0b5cea4b7d
commit 533d09ef71
1 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
ffa9604027820982f700701359f68f151efbc317
View File

@ -34,6 +34,23 @@
"parentUuid": "6bf8b445_73783efd",
"revId": "ffa9604027820982f700701359f68f151efbc317",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "c40e8adc_f839ba4f",
"filename": "statusbot/bot.py",
"patchSetId": 3
},
"lineNbr": 134,
"author": {
"id": 5263
},
"writtenOn": "2021-11-10T17:44:12Z",
"side": 1,
"message": "Nah, this is fine, I just wasn\u0027t sure if the point of this function was to guard against a missing section raising configparser.NoSectionError but now that I play with it a bit more I see that a missing option even raises configparser.NoOptionError as well. However the entire function could simply be:\n\n return config.get(section, name, fallback\u003dNone)\n\nThe fallback keyword argument seems to be sufficient to avoid both exceptions. This probably makes the convenience wrapper itself a questionable bit of added complexity.",
"revId": "ffa9604027820982f700701359f68f151efbc317",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}