opendev
/
statusbot
Code Issues Proposed changes

Update patch set 3 

Patch Set 3: Code-Review-1

(2 comments)

Patch-set: 3
Label: Code-Review=-1
This commit is contained in:
Gerrit User 4146 2017-07-10 23:05:09 +00:00 committed by Gerrit Code Review
parent 0da1015fce
commit 540c04cec7
1 changed files with 38 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
b18509e936c3afcada122b0da9e5a39f9b619aa1 Normal file
View File

@ -0,0 +1,38 @@
{
"comments": [
{
"key": {
"uuid": "3f1d235d_303678e9",
"filename": "statusbot/bot.py",
"patchSetId": 3
},
"lineNbr": 380,
"author": {
"id": 4146
},
"writtenOn": "2017-07-10T23:05:09Z",
"side": 1,
"message": "Here we use self.handle_thanks_command() but below the method name is handle_thanks. They need to be the same. I like changes the method name below to handle_thanks_command to be consistent with the other commands and leave this line as is.",
"revId": "b18509e936c3afcada122b0da9e5a39f9b619aa1",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3f1d235d_b04f2869",
"filename": "statusbot/bot.py",
"patchSetId": 3
},
"lineNbr": 404,
"author": {
"id": 4146
},
"writtenOn": "2017-07-10T23:05:09Z",
"side": 1,
"message": "This method.",
"revId": "b18509e936c3afcada122b0da9e5a39f9b619aa1",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}