opendev
/
statusbot
Code Issues Proposed changes

Update patch set 3 

Patch Set 3: Code-Review+2 Workflow+1

(1 comment)

Patch-set: 3
Reviewer: Gerrit User 7118 <7118@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+2
Label: Workflow=+1
Attention: {"person_ident":"Gerrit User 7118 \u003c7118@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"Ian Wienand replied on the change"}
This commit is contained in:
Gerrit User 7118 2021-11-10 22:04:52 +00:00 committed by Gerrit Code Review
parent ba7aac47ae
commit 603733be31
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
65a2a96119c28b4c5a8ed3de887e23a80d74b694
View File

@ -16,6 +16,24 @@
"message": "I\u0027d be happy to refactor the implementation if you think that is necessary, but we should discuss it in the parent change that introduces the actual BackendInterface.",
"revId": "65a2a96119c28b4c5a8ed3de887e23a80d74b694",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "018a77c7_01d4c57e",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 2
},
"lineNbr": 0,
"author": {
"id": 7118
},
"writtenOn": "2021-11-10T22:04:52Z",
"side": 1,
"message": "I\u0027m 100% sure this could all be written clearer; it sort of made sense when there was only one page but over time it\u0027s grown all these extra things to update. I would make BackendInterface.__init__() abstract and then do like\n\n class WikiPage(BackendInterface):\n def __init__(self, url, pageid, username, password):\n\nand keep all the config parsing in the main() function. Anyway, we don\u0027t need to do that right now, that can follow on",
"parentUuid": "29ab3ec4_def32d53",
"revId": "65a2a96119c28b4c5a8ed3de887e23a80d74b694",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}