opendev
/
statusbot
Code Issues Proposed changes

Update patch set 1 

Patch Set 1:

(1 comment)

Patch-set: 1
CC: Gerrit User 13252 <13252@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Attention: {"person_ident":"Gerrit User 7118 \u003c7118@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"Dr. Jens Harbott (frickler) replied on the change"}
This commit is contained in:
Gerrit User 13252 2021-11-12 07:40:28 +00:00 committed by Gerrit Code Review
parent 4faf78afe5
commit 7430d4559f
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
4c31332e23ed49fe9748d97c5a81b3097836aabc
View File

@ -33,6 +33,24 @@
"message": "Is this maybe supposed to be Bot(SSL, base) ?",
"revId": "4c31332e23ed49fe9748d97c5a81b3097836aabc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "b51b9287_9e4c57ac",
"filename": "statusbot/bot.py",
"patchSetId": 1
},
"lineNbr": 570,
"author": {
"id": 13252
},
"writtenOn": "2021-11-12T07:40:28Z",
"side": 0,
"message": "I think that that is pretty likely the issue, because the SSL mixin does some patching in its init() before calling super(), which comes late when the base class is referenced before.\nNote that even switching this would still make the resulting class (SSL, SASL, base) instead of (SASL, SSL, base) which we had before, but SASL is calling super() first, so that hopefully shouldn\u0027t matter as much.",
"parentUuid": "bdce24ca_13ba7e31",
"revId": "4c31332e23ed49fe9748d97c5a81b3097836aabc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}