opendev
/
statusbot
Code Issues Proposed changes

Update patch set 1 

Patch Set 1: Code-Review-1

(3 comments)

Patch-set: 1
Reviewer: Gerrit User 7118 <7118@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1
This commit is contained in:
Gerrit User 7118 2021-11-10 10:23:11 +00:00 committed by Gerrit Code Review
parent a0a31be2a2
commit 9929a49d94
1 changed files with 57 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

57
6c55c0c444ce0af765d5dbe0a3fc856b8e49b271
View File

@ -16,6 +16,63 @@
"message": "@infra-core Please review, this is an useful addition, we are using it internally for more than a month and works well.",
"revId": "6c55c0c444ce0af765d5dbe0a3fc856b8e49b271",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "92518d58_40ec2313",
"filename": "statusbot/bot.py",
"patchSetId": 1
},
"lineNbr": 43,
"author": {
"id": 7118
},
"writtenOn": "2021-11-10T10:23:11Z",
"side": 1,
"message": "this should be \"successpad\"?\n\nalso should define \"thankspad\"?",
"revId": "6c55c0c444ce0af765d5dbe0a3fc856b8e49b271",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "3de2a11b_c72d45bc",
"filename": "statusbot/bot.py",
"patchSetId": 1
},
"lineNbr": 137,
"author": {
"id": 7118
},
"writtenOn": "2021-11-10T10:23:11Z",
"side": 1,
"message": "This isn\u0027t necessary, and gets reset below?",
"revId": "6c55c0c444ce0af765d5dbe0a3fc856b8e49b271",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "5a95dd8a_70179c7c",
"filename": "statusbot/bot.py",
"patchSetId": 1
},
"lineNbr": 174,
"author": {
"id": 7118
},
"writtenOn": "2021-11-10T10:23:11Z",
"side": 1,
"message": "Alternatively, I\u0027m not even sure any of this is necessary? seems like we can just instantiate the backend object and that should read the config in __init__?",
"range": {
"startLine": 168,
"startChar": 1,
"endLine": 174,
"endChar": 53
},
"revId": "6c55c0c444ce0af765d5dbe0a3fc856b8e49b271",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}