Update patch set 4
Patch Set 4: Code-Review-1 (3 comments) Why not implement this as a publisher? Patch-set: 4 Reviewer: Gerrit User 7069 <7069@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=-1
This commit is contained in:
parent
9a43b9bec1
commit
f639b85ca3
|
@ -0,0 +1,55 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"key": {
|
||||
"uuid": "9f6a8fd7_45aaa985",
|
||||
"filename": "statusbot/bot.py",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 45,
|
||||
"author": {
|
||||
"id": 7069
|
||||
},
|
||||
"writtenOn": "2018-04-16T11:04:55Z",
|
||||
"side": 1,
|
||||
"message": "(nit) could put an example config here)",
|
||||
"revId": "67b7d951e25f8a48f7b141a583f6ba0320edae85",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "9f6a8fd7_8589a127",
|
||||
"filename": "statusbot/bot.py",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 83,
|
||||
"author": {
|
||||
"id": 7069
|
||||
},
|
||||
"writtenOn": "2018-04-16T11:04:55Z",
|
||||
"side": 1,
|
||||
"message": "(nit) could make a quick helper function to grab config options with defaults",
|
||||
"revId": "67b7d951e25f8a48f7b141a583f6ba0320edae85",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "9f6a8fd7_45b149e1",
|
||||
"filename": "statusbot/bot.py",
|
||||
"patchSetId": 4
|
||||
},
|
||||
"lineNbr": 138,
|
||||
"author": {
|
||||
"id": 7069
|
||||
},
|
||||
"writtenOn": "2018-04-16T11:04:55Z",
|
||||
"side": 1,
|
||||
"message": "(nit) could have just called self.publish_single",
|
||||
"revId": "67b7d951e25f8a48f7b141a583f6ba0320edae85",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue