From f639b85ca3129b81c8081927c3d2aa61ca4821ff Mon Sep 17 00:00:00 2001 From: Gerrit User 7069 <7069@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Date: Mon, 16 Apr 2018 11:04:55 +0000 Subject: [PATCH] Update patch set 4 Patch Set 4: Code-Review-1 (3 comments) Why not implement this as a publisher? Patch-set: 4 Reviewer: Gerrit User 7069 <7069@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=-1 --- 67b7d951e25f8a48f7b141a583f6ba0320edae85 | 55 ++++++++++++++++++++++++ 1 file changed, 55 insertions(+) create mode 100644 67b7d951e25f8a48f7b141a583f6ba0320edae85 diff --git a/67b7d951e25f8a48f7b141a583f6ba0320edae85 b/67b7d951e25f8a48f7b141a583f6ba0320edae85 new file mode 100644 index 0000000..7ead257 --- /dev/null +++ b/67b7d951e25f8a48f7b141a583f6ba0320edae85 @@ -0,0 +1,55 @@ +{ + "comments": [ + { + "key": { + "uuid": "9f6a8fd7_45aaa985", + "filename": "statusbot/bot.py", + "patchSetId": 4 + }, + "lineNbr": 45, + "author": { + "id": 7069 + }, + "writtenOn": "2018-04-16T11:04:55Z", + "side": 1, + "message": "(nit) could put an example config here)", + "revId": "67b7d951e25f8a48f7b141a583f6ba0320edae85", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + }, + { + "key": { + "uuid": "9f6a8fd7_8589a127", + "filename": "statusbot/bot.py", + "patchSetId": 4 + }, + "lineNbr": 83, + "author": { + "id": 7069 + }, + "writtenOn": "2018-04-16T11:04:55Z", + "side": 1, + "message": "(nit) could make a quick helper function to grab config options with defaults", + "revId": "67b7d951e25f8a48f7b141a583f6ba0320edae85", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + }, + { + "key": { + "uuid": "9f6a8fd7_45b149e1", + "filename": "statusbot/bot.py", + "patchSetId": 4 + }, + "lineNbr": 138, + "author": { + "id": 7069 + }, + "writtenOn": "2018-04-16T11:04:55Z", + "side": 1, + "message": "(nit) could have just called self.publish_single", + "revId": "67b7d951e25f8a48f7b141a583f6ba0320edae85", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + } + ] +} \ No newline at end of file