statusbot/4c31332e23ed49fe9748d97c5a8...

92 lines
3.4 KiB
Plaintext

{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "7a017869_b5505c2c",
"filename": "statusbot/bot.py",
"patchSetId": 1
},
"lineNbr": 563,
"author": {
"id": 7118
},
"writtenOn": "2021-11-12T03:59:24Z",
"side": 0,
"message": "I also manually added \"use_ssl\u003dTrue\" to the [ircbot] section. we shouldn\u0027t have changed the default ... but even then it wouldn\u0027t connect.",
"revId": "4c31332e23ed49fe9748d97c5a81b3097836aabc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "3b4fb949_ff9e5711",
"filename": "statusbot/bot.py",
"patchSetId": 1
},
"lineNbr": 563,
"author": {
"id": 9311
},
"writtenOn": "2021-11-12T10:36:36Z",
"side": 0,
"message": "Oops, use_ssl should have been set to True in the else case.",
"parentUuid": "7a017869_b5505c2c",
"revId": "4c31332e23ed49fe9748d97c5a81b3097836aabc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "bdce24ca_13ba7e31",
"filename": "statusbot/bot.py",
"patchSetId": 1
},
"lineNbr": 570,
"author": {
"id": 7118
},
"writtenOn": "2021-11-12T03:59:24Z",
"side": 0,
"message": "Is this maybe supposed to be Bot(SSL, base) ?",
"revId": "4c31332e23ed49fe9748d97c5a81b3097836aabc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "b51b9287_9e4c57ac",
"filename": "statusbot/bot.py",
"patchSetId": 1
},
"lineNbr": 570,
"author": {
"id": 13252
},
"writtenOn": "2021-11-12T07:40:28Z",
"side": 0,
"message": "I think that that is pretty likely the issue, because the SSL mixin does some patching in its init() before calling super(), which comes late when the base class is referenced before.\nNote that even switching this would still make the resulting class (SSL, SASL, base) instead of (SASL, SSL, base) which we had before, but SASL is calling super() first, so that hopefully shouldn\u0027t matter as much.",
"parentUuid": "bdce24ca_13ba7e31",
"revId": "4c31332e23ed49fe9748d97c5a81b3097836aabc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "f7499183_90f091f9",
"filename": "statusbot/bot.py",
"patchSetId": 1
},
"lineNbr": 570,
"author": {
"id": 9311
},
"writtenOn": "2021-11-12T10:36:36Z",
"side": 0,
"message": "Arg, unfortunately, using `class Bot(SSL, base)` results in\n\n Traceback (most recent call last):\n File \"statusbot/bot.py\", line 612, in \u003cmodule\u003e\n main()\n File \"statusbot/bot.py\", line 597, in main\n _main(args.config)\n File \"statusbot/bot.py\", line 576, in _main\n Bot(channels, nicks, publishers, successlog,\n File \"/lib/python3.8/site-packages/ib3/connection.py\", line 32, in __init__\n super(SSL, self).__init__(*args, **kwargs)\n TypeError: __init__() got an unexpected keyword argument \u0027connect_factory\u0027",
"parentUuid": "b51b9287_9e4c57ac",
"revId": "4c31332e23ed49fe9748d97c5a81b3097836aabc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}