155 lines
4.8 KiB
Plaintext
155 lines
4.8 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "a4e02376_05a6be99",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 1955
|
|
},
|
|
"writtenOn": "2021-11-10T08:00:21Z",
|
|
"side": 1,
|
|
"message": "@infra-core Please review, this is an useful addition, we are using it internally for more than a month and works well.",
|
|
"revId": "6c55c0c444ce0af765d5dbe0a3fc856b8e49b271",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "f2c54c76_d36e25aa",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 9311
|
|
},
|
|
"writtenOn": "2021-11-10T11:41:03Z",
|
|
"side": 1,
|
|
"message": "Thank you for the review!",
|
|
"revId": "6c55c0c444ce0af765d5dbe0a3fc856b8e49b271",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "92518d58_40ec2313",
|
|
"filename": "statusbot/bot.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 43,
|
|
"author": {
|
|
"id": 7118
|
|
},
|
|
"writtenOn": "2021-11-10T10:23:11Z",
|
|
"side": 1,
|
|
"message": "this should be \"successpad\"?\n\nalso should define \"thankspad\"?",
|
|
"revId": "6c55c0c444ce0af765d5dbe0a3fc856b8e49b271",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "ef5911a2_f8e06256",
|
|
"filename": "statusbot/bot.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 43,
|
|
"author": {
|
|
"id": 9311
|
|
},
|
|
"writtenOn": "2021-11-10T11:41:03Z",
|
|
"side": 1,
|
|
"message": "If I understand correctly the wiki configuration, the unnamed document is the status one, then success and thanks are extra configuration, and they are currently missing indeed.",
|
|
"parentUuid": "92518d58_40ec2313",
|
|
"revId": "6c55c0c444ce0af765d5dbe0a3fc856b8e49b271",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "3de2a11b_c72d45bc",
|
|
"filename": "statusbot/bot.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 137,
|
|
"author": {
|
|
"id": 7118
|
|
},
|
|
"writtenOn": "2021-11-10T10:23:11Z",
|
|
"side": 1,
|
|
"message": "This isn\u0027t necessary, and gets reset below?",
|
|
"revId": "6c55c0c444ce0af765d5dbe0a3fc856b8e49b271",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "2790a81a_f17c48dd",
|
|
"filename": "statusbot/bot.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 137,
|
|
"author": {
|
|
"id": 9311
|
|
},
|
|
"writtenOn": "2021-11-10T11:41:03Z",
|
|
"side": 1,
|
|
"message": "I think this is how the existing WikiPage works: the `pageid` gets mutated for each page. This is just keeping the same logic.",
|
|
"parentUuid": "3de2a11b_c72d45bc",
|
|
"revId": "6c55c0c444ce0af765d5dbe0a3fc856b8e49b271",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "5a95dd8a_70179c7c",
|
|
"filename": "statusbot/bot.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 174,
|
|
"author": {
|
|
"id": 7118
|
|
},
|
|
"writtenOn": "2021-11-10T10:23:11Z",
|
|
"side": 1,
|
|
"message": "Alternatively, I\u0027m not even sure any of this is necessary? seems like we can just instantiate the backend object and that should read the config in __init__?",
|
|
"range": {
|
|
"startLine": 168,
|
|
"startChar": 1,
|
|
"endLine": 174,
|
|
"endChar": 53
|
|
},
|
|
"revId": "6c55c0c444ce0af765d5dbe0a3fc856b8e49b271",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "c94a7e5b_5bce7732",
|
|
"filename": "statusbot/bot.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 174,
|
|
"author": {
|
|
"id": 9311
|
|
},
|
|
"writtenOn": "2021-11-10T11:41:03Z",
|
|
"side": 1,
|
|
"message": "I didn\u0027t want to refactor the existing logic, but I think a simpler solution would be to remove the backend state and simply pass the page information to the load and save function.\n\nI don\u0027t understand what you are suggesting, should the __init__ function takes either a wiki pageid/pageurl, or a padurl argument?",
|
|
"parentUuid": "5a95dd8a_70179c7c",
|
|
"range": {
|
|
"startLine": 168,
|
|
"startChar": 1,
|
|
"endLine": 174,
|
|
"endChar": 53
|
|
},
|
|
"revId": "6c55c0c444ce0af765d5dbe0a3fc856b8e49b271",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |