opendev/storyboard-webclient
Code Issues Proposed changes

Update patch set 4

Browse Source 
Patch Set 4: Code-Review-1

(4 comments)

I noticed a couple more UI inconsistencies, but other than those it looks fine to me now.

Patch-set: 4
Label: Code-Review=-1
This commit is contained in:
Gerrit User 16960 2019-06-13 16:44:27 +00:00 committed by Gerrit Code Review
parent 377c446ec8
commit 30867dbc91
2 changed files with 94 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

67
2dfbe97eab57e69f3f6eb7a379d8e4d6039ffff7 Normal file
View File

@ -0,0 +1,67 @@
{
"comments": [
{
"key": {
"uuid": "9fb8cfa7_530155ae",
"filename": "src/app/search/directive/search_results.js",
"patchSetId": 4
},
"lineNbr": 65,
"author": {
"id": 16960
},
"writtenOn": "2019-06-13T16:44:27Z",
"side": 1,
"message": "It just dawned on me that we also already display (some of) the description in the story list, so this probably doesn\u0027t make loads of sense as a column either. It also makes the table really hard to read when selected, so we should work out another way to make full descriptions visible on the story list and remove this for now.",
"range": {
"startLine": 65,
"startChar": 20,
"endLine": 65,
"endChar": 49
},
"revId": "2dfbe97eab57e69f3f6eb7a379d8e4d6039ffff7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_9397cd48",
"filename": "src/app/search/template/story_search_item.html",
"patchSetId": 4
},
"lineNbr": 28,
"author": {
"id": 16960
},
"writtenOn": "2019-06-13T16:44:27Z",
"side": 1,
"message": "If following the below suggestion, this will need to be\n\n !timeCriteria.includes(criteria) \u0026\u0026 criteria !\u003d \u0027status\u0027",
"range": {
"startLine": 28,
"startChar": 17,
"endLine": 28,
"endChar": 49
},
"revId": "2dfbe97eab57e69f3f6eb7a379d8e4d6039ffff7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9fb8cfa7_13a43db9",
"filename": "src/app/search/template/story_search_item.html",
"patchSetId": 4
},
"lineNbr": 30,
"author": {
"id": 16960
},
"writtenOn": "2019-06-13T16:44:27Z",
"side": 1,
"message": "Something like\n\n \u003cspan ng-if\u003d\"criteria \u003d\u003d \u0027status\u0027\"\u003e\n \u003cstory-status-label story\u003d\"story\"/\u003e\n \u003c/span\u003e\n\nwould be nice here.",
"revId": "2dfbe97eab57e69f3f6eb7a379d8e4d6039ffff7",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}

27
d77e153a950ed5d87739ba6d0c19a7451fad4bae Normal file
View File

@ -0,0 +1,27 @@
{
"comments": [
{
"key": {
"uuid": "9fb8cfa7_f3de493c",
"filename": "src/app/search/template/story_search_item.html",
"patchSetId": 4
},
"lineNbr": 34,
"author": {
"id": 16960
},
"writtenOn": "2019-06-13T16:44:27Z",
"side": 0,
"message": "I also just noticed that we don\u0027t use `story-status-label` for the status anymore, it\u0027d be nice to special-case the status column in a similar way to the time related ones to still use this so that the status is displayed consistently everywhere.",
"range": {
"startLine": 34,
"startChar": 4,
"endLine": 34,
"endChar": 39
},
"revId": "d77e153a950ed5d87739ba6d0c19a7451fad4bae",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}