opendev/storyboard-webclient
Code Issues Proposed changes

Enabled eslint:no-underscore-dangle

Browse Source 
Rule enabled, discovered issues resolved.

Change-Id: If5fc53b0f1a6c3a31b4ef8b1858f4ef5d3ea0016
This commit is contained in:
Michael Krotscheck
2015-03-04 16:00:19 -08:00
parent 6f6b07f756
commit ace56c8dc2
3 changed files with 7 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
.eslintrc
View File

@@ -58,7 +58,6 @@
"space-unary-ops": 0, "space-unary-ops": 0,
"no-console": 0, "no-console": 0,
"strict": 0, "strict": 0,
"no-underscore-dangle": 0,
// Stylistic // Stylistic
"indent": [2, 4], "indent": [2, 4],

10
src/app/services/provider/preference.js
View File

@@ -61,7 +61,7 @@ angular.module('sb.services').provider('Preference',
* *
* @returns {deferred.promise|*} * @returns {deferred.promise|*}
*/ */
this._resolveUserPreferences = function () { this.resolveUserPreferences = function () {
var deferred = $q.defer(); var deferred = $q.defer();
// First resolve the session. // First resolve the session.
@@ -118,7 +118,7 @@ angular.module('sb.services').provider('Preference',
} }
} }
} }
return this._save(); return this.save();
}; };
/** /**
@@ -158,7 +158,7 @@ angular.module('sb.services').provider('Preference',
// Store the preference. // Store the preference.
preferences[key] = value; preferences[key] = value;
return this._save(); return this.save();
}; };
/** /**
@@ -168,7 +168,7 @@ angular.module('sb.services').provider('Preference',
var deferred = $q.defer(); var deferred = $q.defer();
// This should never fail, see implementation above. // This should never fail, see implementation above.
this._resolveUserPreferences().then( this.resolveUserPreferences().then(
function (newPrefs) { function (newPrefs) {
preferences = newPrefs; preferences = newPrefs;
deferred.resolve(preferences); deferred.resolve(preferences);
@@ -181,7 +181,7 @@ angular.module('sb.services').provider('Preference',
/** /**
* Private save method. * Private save method.
*/ */
this._save = function () { this.save = function () {
var deferred = $q.defer(); var deferred = $q.defer();
// If preferences are defaults, they won't have a $save() // If preferences are defaults, they won't have a $save()

4
src/app/util/service/last_location.js
View File

@@ -50,7 +50,7 @@ angular.module('sb.util')
/** /**
* Initialize this service. * Initialize this service.
*/ */
_initialize: function () { initialize: function () {
// Register (and disconnect) our listener. // Register (and disconnect) our listener.
$rootScope.$on('$destroy', $rootScope.$on('$destroy',
$rootScope.$on('$locationChangeStart', onLocationChange) $rootScope.$on('$locationChangeStart', onLocationChange)
@@ -62,5 +62,5 @@ angular.module('sb.util')
'use strict'; 'use strict';
// Initialize this service. // Initialize this service.
LastLocation._initialize(); LastLocation.initialize();
}); });