18c94164b1
Patch Set 6: (1 comment) Patch-set: 6 Label: Verified=0
55 lines
1.7 KiB
Plaintext
55 lines
1.7 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"key": {
|
|
"uuid": "3fa7e38b_0e1f0c71",
|
|
"filename": "src/app/util/template/user_typeahead.html",
|
|
"patchSetId": 6
|
|
},
|
|
"lineNbr": 12,
|
|
"author": {
|
|
"id": 5263
|
|
},
|
|
"writtenOn": "2019-10-17T21:24:44Z",
|
|
"side": 1,
|
|
"message": "This edit has introduced an extra space before the closing tag for the span. I have no idea whether that actually matters. also it incorporates a hard tab in the indentation.",
|
|
"revId": "8caf5fced66abb37118ff33d55d156374dd7c4bc",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "3fa7e38b_ae2b5893",
|
|
"filename": "src/app/util/template/user_typeahead.html",
|
|
"patchSetId": 6
|
|
},
|
|
"lineNbr": 52,
|
|
"author": {
|
|
"id": 5263
|
|
},
|
|
"writtenOn": "2019-10-17T21:24:44Z",
|
|
"side": 1,
|
|
"message": "What does switching from user.full_name to formatUserName(user) do here? Is this for improved consistency with the input formatter below?",
|
|
"revId": "8caf5fced66abb37118ff33d55d156374dd7c4bc",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "3fa7e38b_8e1c5c78",
|
|
"filename": "src/app/util/template/user_typeahead.html",
|
|
"patchSetId": 6
|
|
},
|
|
"lineNbr": 52,
|
|
"author": {
|
|
"id": 5263
|
|
},
|
|
"writtenOn": "2019-10-17T21:25:25Z",
|
|
"side": 1,
|
|
"message": "Nevermind, I see Adam\u0027s comment on the previous patchset now. I should read more carefully!",
|
|
"revId": "8caf5fced66abb37118ff33d55d156374dd7c4bc",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
}
|
|
]
|
|
} |