opendev/subunit2sql
Code Issues Proposed changes

Merge "Switch functools partials usage to kwargs"

Browse Source
This commit is contained in:
Jenkins
2015-07-08 21:55:15 +00:00
committed by Gerrit Code Review
parent 441612b759 e5341bbe90
commit 7c8d01b1b7
1 changed files with 8 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
subunit2sql/write_subunit.py
View File

@@ -14,7 +14,6 @@
import copy import copy
import datetime import datetime
import functools
import sys import sys
from oslo_config import cfg from oslo_config import cfg
@@ -59,23 +58,20 @@ def convert_datetime(timestamp):
def write_test(output, start_time, stop_time, status, test_id, metadatas): def write_test(output, start_time, stop_time, status, test_id, metadatas):
write_status = output.status write_status = output.status
kwargs = {}
if 'tags' in metadatas: if 'tags' in metadatas:
tags = metadatas['tags'] tags = metadatas['tags']
write_status = functools.partial(write_status, kwargs['test_tags'] = tags.split(',')
test_tags=tags.split(','))
if 'attrs' in metadatas: if 'attrs' in metadatas:
test_id = test_id + '[' + metadatas['attrs'] + ']' test_id = test_id + '[' + metadatas['attrs'] + ']'
start_time = convert_datetime(start_time) start_time = convert_datetime(start_time)
write_status = functools.partial(write_status, kwargs['timestamp'] = start_time
timestamp=start_time) kwargs['test_id'] = test_id
write_status = functools.partial(write_status, test_id=test_id) write_status(**kwargs)
write_status()
write_status = functools.partial(write_status, test_id=test_id)
if status in STATUS_CODES: if status in STATUS_CODES:
write_status = functools.partial(write_status, kwargs['test_status'] = status
test_status=status, kwargs['timestamp'] = convert_datetime(stop_time)
timestamp=convert_datetime(stop_time)) write_status(**kwargs)
write_status()
def sql2subunit(run_id, output=sys.stdout): def sql2subunit(run_id, output=sys.stdout):