By adding an 'include_attachments' flag to the get_test_runs_by_status
method we can join the Attachments table with the same structure as
the RunMetadata table allowing us to optionally include attachments or
metadata with test_runs filtered by a given status.
Notes on testing:
* As far as I could tell, logstash.o.o doesn't store attachments[1]
so to test this patch you will have to setup/use another subunit2sql
db with attachments stored in it
* you can find the openstack-health patch to render the attachments
in the Needed-By change of the footer of this commit message.
Notes on performance:
* on average loading attachments is about 13% slower when calling this
api with python[2]. The query times in the paste were produced by calling
the api method get_test_runs_by_status_for_run_ids 100x in a for loop with
49 test_runs being returned from the call, which is the number of failures
in the last 10 runs.
[1] http://paste.openstack.org/show/719192/
[2] http://paste.openstack.org/show/738662/
Needed-By: I3ce2fc50ada9462de3df29b5a8b76b12a548fd12
Change-Id: I31468c825cf259b8df62134e578f31d96af6ac75
mccasland, trevor (tm2086)
464a9e0adc