1caff42353
Patch Set 7: (1 comment) Sorry this took so long for me to get back to. This iteration looks better to me. I have one inline question about the potential performance impacts when we set the flag to true, since we end up making the same query (which is mostly the same) twice. We should be able to conditionally add on the other join and attachments values if the flag is true and handle the post processing with a single query. That being said if you didn't test the performance we can leave that as a future optimization (considering how long this sat and things really aren't ever that fast) if you add a todo comment above that block mentioning we can optimize this I'll be fine and we can merge this. Patch-set: 7