From 161906647bcdb901d9f9e6a5923a16f6b9b36cb5 Mon Sep 17 00:00:00 2001 From: Ian Wienand Date: Wed, 22 May 2019 10:46:31 +1000 Subject: [PATCH] Replace skip with errors=ignore Upstream deprecated "skip:" in preference of errors="ignore" [1]. Update playbooks to silence deprecation warning [1] https://github.com/ansible/ansible/commit/e17a2b502d6601be53c60d7ba1c627df419460c9 Change-Id: I72284f6ca8aaaa1ba5f94ad8e654d1b337ae762f --- playbooks/roles/base-repos/tasks/main.yaml | 3 +-- playbooks/roles/disable-puppet-agent/tasks/main.yaml | 3 +-- playbooks/roles/iptables/tasks/main.yaml | 3 +-- playbooks/roles/unbound/tasks/main.yaml | 3 +-- roles/exim/tasks/main.yaml | 3 +-- 5 files changed, 5 insertions(+), 10 deletions(-) diff --git a/playbooks/roles/base-repos/tasks/main.yaml b/playbooks/roles/base-repos/tasks/main.yaml index ca15dce871..7662da1fe0 100644 --- a/playbooks/roles/base-repos/tasks/main.yaml +++ b/playbooks/roles/base-repos/tasks/main.yaml @@ -5,5 +5,4 @@ files: - "{{ ansible_facts.distribution }}.yaml" - "{{ ansible_facts.os_family }}.yaml" - skip: true - loop: "{{ query('first_found', params) }}" + loop: "{{ query('first_found', params, errors='ignore') }}" diff --git a/playbooks/roles/disable-puppet-agent/tasks/main.yaml b/playbooks/roles/disable-puppet-agent/tasks/main.yaml index c6c9a71b1e..2cbf884bb8 100644 --- a/playbooks/roles/disable-puppet-agent/tasks/main.yaml +++ b/playbooks/roles/disable-puppet-agent/tasks/main.yaml @@ -3,8 +3,7 @@ vars: params: files: "{{ distro_lookup_path }}" - skip: true - loop: "{{ query('first_found', params) }}" + loop: "{{ query('first_found', params, errors='ignore') }}" - name: Disable the puppet service service: diff --git a/playbooks/roles/iptables/tasks/main.yaml b/playbooks/roles/iptables/tasks/main.yaml index 314d6adacf..64925e09ea 100644 --- a/playbooks/roles/iptables/tasks/main.yaml +++ b/playbooks/roles/iptables/tasks/main.yaml @@ -43,8 +43,7 @@ vars: params: files: "{{ distro_lookup_path }}" - skip: true - loop: "{{ query('first_found', params) }}" + loop: "{{ query('first_found', params, errors='ignore') }}" - name: Enable iptables service service: diff --git a/playbooks/roles/unbound/tasks/main.yaml b/playbooks/roles/unbound/tasks/main.yaml index 1d6b708ce2..c3e4ad7ff6 100644 --- a/playbooks/roles/unbound/tasks/main.yaml +++ b/playbooks/roles/unbound/tasks/main.yaml @@ -3,8 +3,7 @@ vars: params: files: "{{ distro_lookup_path }}" - skip: true - loop: "{{ query('first_found', params) }}" + loop: "{{ query('first_found', params, errors='ignore') }}" - name: Install unbound package: diff --git a/roles/exim/tasks/main.yaml b/roles/exim/tasks/main.yaml index ca983253bc..0ba366a450 100644 --- a/roles/exim/tasks/main.yaml +++ b/roles/exim/tasks/main.yaml @@ -11,8 +11,7 @@ vars: params: files: "{{ distro_lookup_path }}" - skip: true - loop: "{{ query('first_found', params) }}" + loop: "{{ query('first_found', params, errors='ignore') }}" - name: Write Exim defaults file template: