opendev/system-config
Code Issues Proposed changes

Merge "Make links in CI results optional"

Browse Source
This commit is contained in:
Zuul 2018-07-08 14:24:14 +00:00 committed by Gerrit Code Review
commit 181bf83356
1 changed files with 13 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
modules/openstack_project/files/gerrit/hideci.js
View File

@ -110,8 +110,13 @@ var ci_parse_results = function($panel) {
if (test_results !== null) { if (test_results !== null) {
test_results.each(function(i, li) { test_results.each(function(i, li) {
var result = {}; var result = {};
result["name"] = $(li).find("span.comment_test_name").find("a")[0].innerHTML; if ($(li).find("a").length > 0) {
result["link"] = $(li).find("span.comment_test_name").find("a")[0]; result["name"] = $(li).find("span.comment_test_name").find("a")[0].innerHTML;
result["link"] = $(li).find("span.comment_test_name").find("a")[0];
}
else {
result["name"] = $(li).find("span.comment_test_name")[0].innerHTML;
}
result["result"] = $(li).find("span.comment_test_result")[0]; result["result"] = $(li).find("span.comment_test_result")[0];
result_list.push(result); result_list.push(result);
}); });
@ -315,7 +320,12 @@ var ci_display_results = function(comments) {
for (var j = 0; j < comment.results.length; j++) { for (var j = 0; j < comment.results.length; j++) {
var result = comment.results[j]; var result = comment.results[j];
var tr = $("<tr>"); var tr = $("<tr>");
tr.append($("<td>").append($(result["link"]).clone())); if ("link" in result) {
tr.append($("<td>").append($(result["link"]).clone()));
}
else {
tr.append($("<td>").text(result["name"]));
}
tr.append($("<td>").append($(result["result"]).clone())); tr.append($("<td>").append($(result["result"]).clone()));
$(table).append(tr); $(table).append(tr);
} }