opendev/system-config
Code Issues Proposed changes

Expose projects_config parameter in review/review_dev classes

Browse Source 
The value for that parameter is hardcoded in a nested class,
it should be defined in the outer class to allow user defined
value.

Change-Id: I1715d6a6cff52b9cc224e360104ef9438b6dcf30
Closes-Bug: 1388144
This commit is contained in:
Ricardo Carrillo Cruz 2014-10-31 16:34:55 +01:00
parent ff55bbcbfc
commit 1c0b2915f4
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
modules/openstack_project/manifests/review.pp
View File

@ -80,6 +80,7 @@ class openstack_project::review (
$swift_username = '',
$swift_password = '',
$project_config_repo = '',
$projects_config = 'openstack_project/review.projects.ini.erb',
) {
class { 'project_config':
@ -122,8 +123,7 @@ class openstack_project::review (
acls_dir => $::project_config::gerrit_acls_dir,
notify_impact_file => $::project_config::gerrit_notify_impact_file,
projects_file => $::project_config::jeepyb_project_file,
projects_config =>
'openstack_project/review.projects.ini.erb',
projects_config => $projects_config,
github_username => 'openstack-gerrit',
github_oauth_token => $github_oauth_token,
github_project_username => $github_project_username,

4
modules/openstack_project/manifests/review_dev.pp
View File

@ -23,6 +23,7 @@ class openstack_project::review_dev (
$swift_username = '',
$swift_password = '',
$project_config_repo = '',
$projects_config = 'openstack_project/review-dev.projects.ini.erb',
) {
realize (
@ -57,8 +58,7 @@ class openstack_project::review_dev (
acls_dir => $::project_config::gerrit_acls_dir,
notify_impact_file => $::project_config::gerrit_notify_impact_file,
projects_file => $::project_config::jeepyb_project_file,
projects_config =>
'openstack_project/review-dev.projects.ini.erb',
projects_config => $projects_config,
github_username => 'openstack-gerrit-dev',
github_oauth_token => $github_oauth_token,
github_project_username => $github_project_username,