opendev
/
system-config
Code Issues Proposed changes

Allow nonzero puppet exit codes when launching 

* launch/launch-node.py: Now that we're using --detailed-exit-codes
with puppet, we should not abort when the ssh call exits nonzero.
Puppet explicitly returns nonzero codes which indicate success
conditions, and we already have a function in place to interpret
them.

Change-Id: If66d345902d05fa0898d202f5f71c087df9f4ce7
This commit is contained in:
Jeremy Stanley 2014-10-25 00:48:36 +00:00
parent ccfa948602
commit 2f3127c458
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
launch/launch-node.py
View File

@ -128,7 +128,7 @@ def bootstrap_server(server, admin_pass, key, cert, environment, name,
"--server %s "
"--detailed-exitcodes "
"--no-daemonize --verbose --onetime --pluginsync true "
"--certname %s" % (environment, puppetmaster, certname))
"--certname %s" % (environment, puppetmaster, certname), error_ok=True)
utils.interpret_puppet_exitcodes(rc, output)
ssh_client.ssh("reboot")