Browse Source

Don't use loops with package task

We can directly pass a list of packages to the package task in ansible,
this will help save us some times on run times.

Change-Id: I9b26f4f4f9731dc7d32186584620f1cec04b7a81
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
changes/41/597241/3
Paul Belanger 4 years ago
parent
commit
30c2e03281
  1. 6
      playbooks/roles/base-server/tasks/main.yaml
  2. 7
      playbooks/roles/pip3/tasks/main.yaml
  3. 9
      roles/puppet-install/tasks/puppet-install/trusty.yaml
  4. 7
      roles/puppet-install/tasks/puppet-install/xenial.yaml

6
playbooks/roles/base-server/tasks/main.yaml

@ -1,8 +1,7 @@
- name: Install base packages
package:
state: present
name: '{{ item }}'
loop: '{{ base_packages }}'
name: "{{ base_packages }}"
- name: Include OS-specific variables
include_vars: "{{ lookup('first_found', params) }}"
@ -15,8 +14,7 @@
- name: Install distro specific packages
package:
state: present
name: '{{ item }}'
loop: '{{ distro_packages }}'
name: "{{ distro_packages }}"
- name: Increase syslog message size in order to capture python tracebacks
copy:

7
playbooks/roles/pip3/tasks/main.yaml

@ -1,6 +1,5 @@
- name: Install pip and virtualenv
package:
name: "{{ item }}"
loop:
- python3-pip
- python3-virtualenv
name:
- python3-pip
- python3-virtualenv

9
roles/puppet-install/tasks/puppet-install/trusty.yaml

@ -16,10 +16,9 @@
- name: Install puppet packages
package:
state: present
name: '{{ item }}'
loop:
- puppet
- ruby
name:
- puppet
- ruby
# wipe out templatedir so we don't get warnings
- name: Remove templatedir
lineinfile:
@ -54,4 +53,4 @@
name: puppet
state: stopped
enabled: no
become: yes
become: yes

7
roles/puppet-install/tasks/puppet-install/xenial.yaml

@ -11,10 +11,9 @@
- name: Install puppet packages
package:
state: present
name: '{{ item }}'
loop:
- puppet
- ruby
name:
- puppet
- ruby
# wipe out templatedir so we don't get warnings
- name: Remove templatedir

Loading…
Cancel
Save